Skip to content
0
  • Home
  • Piero Bosio
  • Blog
  • World
  • Fediverso
  • News
  • Categories
  • Old Web Site
  • Recent
  • Popular
  • Tags
  • Users
  • Home
  • Piero Bosio
  • Blog
  • World
  • Fediverso
  • News
  • Categories
  • Old Web Site
  • Recent
  • Popular
  • Tags
  • Users
Skins
  • Light
  • Brite
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse

Piero Bosio Social Web Site Personale Logo Fediverso

Social Forum federato con il resto del mondo. Non contano le istanze, contano le persone
jorendorff@federate.socialundefined

Jason Orendorff

@jorendorff@federate.social
About
Posts
3
Topics
0
Shares
0
Groups
0
Followers
0
Following
0

View Original

Posts

Recent Best Controversial

  • PSA: Did you know that it’s **unsafe** to put code diffs into your commit messages?
    jorendorff@federate.socialundefined jorendorff@federate.social

    @DecaturNature Exception: github does apply patches in case of rebase/merge, but those are patches specifically generated by diffing trees, never patches provided by users (much less commit messages).

    I'm not sure we even do that using any kind of custom code - probably we just use git.

    I'm a GitHub employee.

    To quibble with the framing of the original: the unsafe behavior is using `patch` to apply patches - good reminder to be super careful doing that. yow

    Uncategorized

  • PSA: Did you know that it’s **unsafe** to put code diffs into your commit messages?
    jorendorff@federate.socialundefined jorendorff@federate.social

    @DecaturNature to be clear: github doesn't apply patches to your code.* The way `git push` works is not based on patches. That is, as the level of surprise in the original post suggests, not how any of this works.

    But `patch` and `git-am` do take arbitrary text input and apply it as a patch, and patches are not a good data format. `patch` for sure can be tricked.

    *see next message

    Uncategorized

  • PSA: Did you know that it’s **unsafe** to put code diffs into your commit messages?
    jorendorff@federate.socialundefined jorendorff@federate.social

    @DecaturNature I think this must be a git-am thing. Absolutely wild.

    Uncategorized
  • Login

  • Login or register to search.
  • First post
    Last post