@heiglandreas Have you actually read the commit message in question? It’s perfectly reasonable.
undefined
Michael Stapelberg 🐧🐹😺
@zekjur@mas.to
Posts
-
PSA: Did you know that it’s **unsafe** to put code diffs into your commit messages? -
PSA: Did you know that it’s **unsafe** to put code diffs into your commit messages?FWIW, git cherry-pick works as expected (at least)
-
PSA: Did you know that it’s **unsafe** to put code diffs into your commit messages?PSA: Did you know that it’s **unsafe** to put code diffs into your commit messages?
Like https://github.com/i3/i3/pull/6564 for example
Such diffs will be applied by patch(1) (also git-am(1)) as part of the code change!
This is how a sleep(1) made it into i3 4.25-2 in Debian unstable.