Has anyone done research on the best place within a pull request to hide stuff?'nI'm thinking it's 80% through a good sized PR.
-
Has anyone done research on the best place within a pull request to hide stuff?
I'm thinking it's 80% through a good sized PR. At that point the reviewer is probably tired, but you're past the end where they might scroll to and perk back up.
-
Has anyone done research on the best place within a pull request to hide stuff?
I'm thinking it's 80% through a good sized PR. At that point the reviewer is probably tired, but you're past the end where they might scroll to and perk back up.
@preinheimer Big changes to package-lock.json, for NodeJS apps. Big changes get hidden in GitHub's PR interface. Also, I'll assume that any changes to package-lock.json were auto-generated. Also, I have no effin idea what the syntax of that file is. Even if there is crazy broken crap in there, I just assume that it's second or third level dependencies that are absolutely impossible to fix or change.
-
Has anyone done research on the best place within a pull request to hide stuff?
I'm thinking it's 80% through a good sized PR. At that point the reviewer is probably tired, but you're past the end where they might scroll to and perk back up.
@preinheimer I'd say someqhere between file 235 and 317 of that 623 File PR with 12.437 changed lines....
-
@preinheimer I'd say someqhere between file 235 and 317 of that 623 File PR with 12.437 changed lines....
@heiglandreas @preinheimer that's too big, though. Pushing that kind of change requires a lot of trust.